Switch to adapter approach for PSR-16 instead of directly extending it #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like the warnings and other goofiness we had to deal with by directly extending the PSR-16 interface.
With this approach, we can directly depend on the
Vectorface\Cache\Cacheinterface instead ofPsr\SimpleCache\CacheInterfaceand if we ever actually need interop with PSR-16, we can just donew SimpleCacheAdapter($cache)to wrap it in something that actually implementsPsr\SimpleCache\CacheInterfaceand call it a day.I'll probably tag a v0.2 version along with the planned increment/decrement additions which will be in a PR to follow. I'll probably not make a separate interface for that seeing as we're moving away from directly extending PSR-16; I can just add it to our existing Cache interface I suppose.