+
Skip to content

Conversation

andy24Dai
Copy link
Contributor

No description provided.

@andy24Dai andy24Dai requested a review from honzikschenk July 17, 2025 21:37
Copy link
Contributor

@honzikschenk honzikschenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change


self._images_path = images_path
self.__image_folder_path = images_path
self.__virtual_camera = pyvirtualcam.Camera(IMAGE_SIZE[0], IMAGE_SIZE[1], CAMERA_FPS)
Copy link
Contributor

@honzikschenk honzikschenk Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run pyvirtualcam.Camera() in the create function, check for issues, then pass it here?

@andy24Dai andy24Dai force-pushed the hitl-camera-emulator branch 2 times, most recently from 2410827 to 45a88e4 Compare July 22, 2025 15:21
Copy link
Contributor

@honzikschenk honzikschenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, approved!

@andy24Dai andy24Dai force-pushed the hitl-camera-emulator branch from 0893a5b to e0a51d9 Compare July 24, 2025 17:46
@andy24Dai andy24Dai merged commit 14dae38 into main Jul 24, 2025
1 check passed
@andy24Dai andy24Dai deleted the hitl-camera-emulator branch July 24, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载