+
Skip to content

Update dev dependencies, format code, and expand readme #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

chrstahl
Copy link
Contributor

Changes requested by reviewer 1 of JOSS paper. Fixes application for newer M2 machines and provides clearly install instructions for building from source. Also fixes a bug when attempting to annotate using the finder but having no text selected.

Copy link
Collaborator

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add instructions on how the code was formatted? Was it prettier? Can you add a command to package.json if that's the case?

@chrstahl chrstahl requested a review from shapiromatron March 4, 2024 15:47
@chrstahl
Copy link
Contributor Author

chrstahl commented Mar 4, 2024

@shapiromatron Had just run it through prettier extension in VSCode, but added a script to package.json so now the entire project can be formatted with

yarn format

@shapiromatron shapiromatron changed the title Updated dev decencies and expanding readme for clarity. Update dev dependencies, format code, and expand readme Mar 4, 2024
Copy link
Collaborator

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shapiromatron shapiromatron merged commit 07b47c1 into USEPA:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载