Unified the build env representation! #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case even though originally the two structs served different purposes, with ArtifactNodeRepr to be more of a clean presentation layer that would serialize into the build artifact and DependencyNode to be the deserialized representation for the lower level service and project yamls, ultimately they differed very little and for presentation purposes we can rely on Serde's attributes to skip or alias fields, removing the need for a purely presentational struct.
Settled on ArtifactNodeRepr with 3 additional fields taken from the now removed DependencyNode.
The 3 fields are:
stack_graph
input_spec
dependency_names (previously dependencies)
Renamed fields on ArtifactNodeRepr
inputs -> mapped_inputs