Add MSYS2 MinGW support and fix MSVC debug builds #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CMakeLists.txt: - define WIN32_LEAN_AND_MEAN (fixes mingw build) - ServMain.cpp, SrvCtrl.cpp: - include shellapi.h (fixes mingw build)
- defer to preexisting CMAKE_MSVC_RUNTIME_LIBRARY value when defined - don't specify "/EHa" compile option
|
The Codacy findings are false positives. shellapi.h is a standard Windows header: https://learn.microsoft.com/en-us/windows/win32/api/shellapi/ Without this, MinGW builds will not succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIN32_LEAN_AND_MEANon Windows (MinGW build fix, and may reduce library size)CMAKE_MSVC_RUNTIME_LIBRARYif not already defined by an upstream project (fixes MSVC debug builds)add_compile_options("/EHa")to MSVC-only section, but also comment it out because it seems dangerousFILE_SET HEADERSstuff)shellapi.h(MinGW build fix)