+
Skip to content

feat(deep-purple-checks): allow to pass app name explicitly #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025

Conversation

pmlanger
Copy link
Contributor

@pmlanger pmlanger commented Jul 14, 2025

https://typeform.atlassian.net/browse/PLT-2115

Allow passing in the app name for deep-purple-checks Github workflow explicitly.

Not all repositories define the frontend app name in the root package.json. This is for example the case for bob-the-builder, our builder frontend app.

Passing the app name explicitly is more obvious and less error-prone than trying to find the correct app name in multiple package.json files.

@pmlanger pmlanger force-pushed the PLT-2115-allow-explicit-app-name branch from ed56200 to 78176a8 Compare July 14, 2025 07:55
@pmlanger pmlanger marked this pull request as ready for review July 14, 2025 13:11
@pmlanger pmlanger requested a review from a team as a code owner July 14, 2025 13:11
Copy link

gitstream-cm bot commented Jul 14, 2025

🥷 Code experts: kb-typeform

kb-typeform has most 👩‍💻 activity in the files.
kb-typeform has most 🧠 knowledge in the files.

See details

.github/workflows/deep-purple-checks.yml

Activity based on git-commit:

kb-typeform
JUL
JUN
MAY
APR
MAR 66 additions & 6 deletions
FEB

Knowledge based on git-blame:
kb-typeform: 93%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@pmlanger pmlanger merged commit 1decf9a into main Jul 15, 2025
10 checks passed
@pmlanger pmlanger deleted the PLT-2115-allow-explicit-app-name branch July 15, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载