+
Skip to content

feat: update examples #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: 1.1.x
Choose a base branch
from
Open

feat: update examples #2650

wants to merge 13 commits into from

Conversation

ashaffah
Copy link
Contributor

@ashaffah ashaffah commented Jul 5, 2025

PR Info

New Features

  • feat: add seeder example to jsonrpsee_example

Update Dependencies

  • chore: update dependencies in Cargo.toml for loco_example and migration to latest versions
  • chore: update dependencies in Cargo.toml for loco_seaography example and migration to latest version

Fix

  • fix: JWT expiration handling on loco_seaography example
  • fix: Validator email on users models Deserialization loco_seaography example

Please correct me if I made a mistake, thanks

Copy link
Member

@Expurple Expurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Although, I wonder if there would be too many conflicts when cherry-picking this into master (2.0.0). Maybe it would make more sense to implement directly on master and just leave 1.1.x behind. But you've already implemented it for 1.1.x, so why not merge into 1.1.x anyway...

@ashaffah
Copy link
Contributor Author

ashaffah commented Jul 6, 2025

Looks good to me, thank you!

Although, I wonder if there would be too many conflicts when cherry-picking this into master (2.0.0). Maybe it would make more sense to implement directly on master and just leave 1.1.x behind. But you've already implemented it for 1.1.x, so why not merge into 1.1.x anyway...

Okay, I will immediately implement it in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载