[BUG][MySQL] Isolation level not respected when used with access mode #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsolationLevel not respected in some cases
tyt2y3
approved these changes
Dec 23, 2024
🎉 Released In 1.1.3 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Hi, I discovered this while writing some data migration logic using
IsolationLevel::Serializable, yet getting some results which where definitely not serializable (locks not applied). So I checked the sea_orm transaction code and realized that, if you specify anAccessModetogether with yourIsolationLevelwhenbegin_with_config(), sea_orm does this in two statements. This is HIGHLY problematic as MySQL expects this to be one query (https://dev.mysql.com/doc/refman/8.0/en/set-transaction.html) and reverts theIsolationLevelsetting back to the default, which isConsistentRead.This pull requests fixes this issue. Considering that this can very easily result in some very bad data issues, I would consider this a very high urgency issue!!
Bug Fixes
AccessMode, yourIsolationLevelsetting is ignored (very bad).Changes