Insert many allow active models to have different column set #2433
Conversation
|
I believe this should have solved the problem once and for all. Since this is changing a core part of the library, we should test it more to prevent regression. The safest way might be to have a new method |
src/query/insert.rs
Outdated
| for col in columns.iter() { | ||
| self.columns.push(col.is_some()); | ||
| } |
There was a problem hiding this comment.
thanks. self.columns is really for use with add(). so should we do self.columns.clear() first?
There was a problem hiding this comment.
Okay, reset (clear) it before altering it seems safer.
There was a problem hiding this comment.
Or simply replace the columns vector, isn't this more readable?
self.columns = columns.iter().map(Option::is_some).collect();
🎉 Released In 1.1.3 🎉Thank you everyone for the contribution! |
Fixes #1407
This requires a new feature in sea-query, Value::as_null