+
Skip to content

❌ Deprecate concat_map #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

❌ Deprecate concat_map #3

merged 1 commit into from
Mar 30, 2022

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Mar 30, 2022 •
edited
Loading

It is very unclear to me which type this function should have, and currently it is not used. There are seven combinations to consider:

val concat_map : f:('a -> 'b bwd/list) -> 'a bwd/list -> 'b bwd/list
(* A bwd/list represents an independent option, except that
   the list-list-list case is exactly List.concat_map. *)

I wonder which one is the most natural, most "well-typed" one?

@favonia
❌ Prepare to remove concat_map
f7c91a8 
It is very unclear to me which type this function should have,
and currently it is not used.
@favonia favonia requested a review from jonsterling March 30, 2022 00:44
@favonia favonia changed the title ❌ Prepare to remove concat_map ❌ Deprecate concat_map Mar 30, 2022
jonsterling
jonsterling approved these changes Mar 30, 2022
View reviewed changes
Copy link

@jonsterling jonsterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur.

@favonia favonia merged commit 6c6efe2 into main Mar 30, 2022
@favonia favonia deleted the no-concat-map branch March 30, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsterling jonsterling jonsterling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@favonia @jonsterling
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载