Поддержка конфигураций на английском коде #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
unichkin
reviewed
Sep 12, 2024
There was a problem hiding this comment.
@Pr-Mex явных проблем не вижу. Но если количество таких проверок будет возрастать - я бы добавил асбтракцию над именами... Т.е. не проверять каждый раз на перечень свойств, а определить отдельно коллекцию свойств для проверки. В которой ключ "Ссылка" будет иметь значения "Ссылка; Ref" - и проверять вхождение в список. Возможно, стоит так сделать сразу - оставляю решение за тобой.
|
run tests |
1 similar comment
|
run tests |
Pr-Mex
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Нужно заменить
СтрНайти
на
Найти
Иначе ломается совместимость с 8.2
|
@ava1c |
|
@Pr-Mex поменял на Найти() |
|
run tests |
|
@ava1c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
реализация #2198
сделанные изменения
добавлена проверка значений возвращаемых платформой на английском языке
с этими изменениями у меня работает тестирование УНФ переведённой на английский код