+
Skip to content
This repository was archived by the owner on Dec 26, 2022. It is now read-only.

✨ Added 12 endpoints to Channel #337

Merged
merged 22 commits into from
Dec 31, 2021
Merged

✨ Added 12 endpoints to Channel #337

merged 22 commits into from
Dec 31, 2021

Conversation

darvil82
Copy link
Contributor

@darvil82 darvil82 commented Dec 30, 2021 •
edited
Loading

Changes

  • adds:
    • New Thread class, which PrivateThread and PublicThread will inherit from.
    • 8 methods to Thread:
      • start_with_message
      • start
      • join
      • add_member
      • leave
      • remove_member
      • get_member
      • list_members
    • 4 methods to Channel:
      • list_active_threads
      • list_public_archived_threads
      • list_private_archived_threads
      • list_joined_private_archived_threads

Check off the following

  • I have tested my changes with the current requirements
  • My Code follows the pep8 code style.

@trag1c trag1c added the enhancement New feature or request label Dec 30, 2021
@codecov
Copy link

codecov bot commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #337 (29bd7b8) into main (6a4b2b5) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   90.00%   90.54%   +0.54%     
==========================================
  Files           9        8       -1     
  Lines         100       74      -26     
==========================================
- Hits           90       67      -23     
+ Misses         10        7       -3
Impacted Files Coverage Δ
tests/_utils.py 0.00% <0.00%> (-100.00%) ⬇️
tests/core/test_heartbeat.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a4b2b5...29bd7b8. Read the comment docs.

trag1c
trag1c suggested changes Dec 30, 2021
View reviewed changes
Copy link
Member

@trag1c trag1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing default values (|default| data:...) in many places in the docstrings, please update that :]

Enderchief
Enderchief suggested changes Dec 30, 2021
View reviewed changes
Copy link
Member

@Enderchief Enderchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All async functions should have |coro| in the 0th line of the docstring. This is the same line where the triple quotes begin.

@darvil82 @trag1c
💬 Apply suggestions from code review
9d76c63 
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Sigmanificient
Sigmanificient suggested changes Dec 30, 2021
View reviewed changes
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typing stuff and maybe missing 2 await?

@Enderchief
Copy link
Member

Can you run black over all the files commit

darvil82 and others added 4 commits December 30, 2021 19:16
@darvil82 @Sigmanificient @trag1c
Apply suggestions from code review
eb269fb 
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
@darvil82
💬 working on suggestions
9f51d5f
@darvil82
💬 resolve conflicts
2a71432
@darvil82
🎨 ran black and fixed Optional thing
8ab8c11
zunda-arrow
zunda-arrow suggested changes Dec 30, 2021
View reviewed changes
Copy link
Member

@zunda-arrow zunda-arrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the class thing

zunda-arrow
zunda-arrow reviewed Dec 30, 2021
View reviewed changes
Sigmanificient
Sigmanificient approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way better!

zunda-arrow
zunda-arrow reviewed Dec 30, 2021
View reviewed changes
zunda-arrow
zunda-arrow approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@zunda-arrow zunda-arrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets speedrun merging this 🚀

@trag1c trag1c removed the request for review from Sigmanificient December 30, 2021 21:03
@trag1c trag1c requested review from Enderchief and trag1c December 30, 2021 21:03
trag1c
trag1c suggested changes Dec 30, 2021
View reviewed changes
@darvil82 @trag1c
Update pincer/objects/guild/channel.py
fb4831e 
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
@darvil82
Copy link
Contributor Author

I was thinking that it would probably be better to place all the thread related methods into the Thread class, instead of cluttering the Channel. Will do, unless it is preferred like this.

Enderchief
Enderchief approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@Enderchief Enderchief left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Don't merge yet

@darvil82 darvil82 requested a review from Enderchief December 31, 2021 13:09
Enderchief
Enderchief approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@Enderchief Enderchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Enderchief Enderchief merged commit ff77ea5 into Pincer-org:main Dec 31, 2021
@darvil82 darvil82 deleted the channel_wip branch December 31, 2021 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@Enderchief Enderchief Enderchief approved these changes

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@zunda-arrow zunda-arrow zunda-arrow approved these changes

@trag1c trag1c trag1c approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@darvil82 @Enderchief @Sigmanificient @zunda-arrow @trag1c
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载