-
Notifications
You must be signed in to change notification settings - Fork 365
Merge dev to main for v1.1.1 #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 609090874
PiperOrigin-RevId: 609143233
PiperOrigin-RevId: 610787648
PiperOrigin-RevId: 610789991
PiperOrigin-RevId: 610927735
PiperOrigin-RevId: 611617505
…n preparation for generalization to more models. PiperOrigin-RevId: 615558614
PiperOrigin-RevId: 615594853
Text color changing was a bit jarring, so set default range to half of the color scale. Intensity slider now changes the scale range as well as gamma. PiperOrigin-RevId: 615821669
- <lit-text-chips> as version of <lit-token-chips> for running text. - Clean up some redundant CSS names and rules in token_chips.css. PiperOrigin-RevId: 616166852
Toggle icon to switch between this and the regular background highlight. PiperOrigin-RevId: 616175592
…dows PiperOrigin-RevId: 616236748
…mple comparison. With this version, only the selected datapoint will be editable, not the pinned one. PiperOrigin-RevId: 616246154
This doesn't rename the classes; will do that in a follow-up. PiperOrigin-RevId: 616256449
PiperOrigin-RevId: 616272334
Left-side toolbar controls were one long non-wrapping block, so if the module was narrow enough these would clip. This splits them into two blocks, allowing them to wrap, and adds a spacer to maintain the intended positioning. PiperOrigin-RevId: 616319869
Instead of matching segment prefixes, this treats the full match as it's own segment. Use this instead of ugly lookbehind assertions for line and paragraph splitting. PiperOrigin-RevId: 618012304
PiperOrigin-RevId: 619316810
PiperOrigin-RevId: 619324011
PiperOrigin-RevId: 620011664
PiperOrigin-RevId: 620880580
PiperOrigin-RevId: 620964615
PiperOrigin-RevId: 621605910
PiperOrigin-RevId: 622202706
Summary of changes: * Wherever possible, use `keras.ops` for Tensor operations. These functions are designed to create and operate over Tensors from any of the Keras 3 backends. * Identified a common API surface for salience predictions that supports all existing (and likely any future) Keras 3 backends. Functions implementing this API shoudl be named `_pred_{framework}` and return a tuple of the GradNorm and GradDotInput salience scores. * Refactors `KerasSalienceModel._pred()` to perform common operations for data before calling out to backend-specific prediction functions. * Extracts TensorFlow code in `KerasSalienceModel` to a new `_pred_tf()` function. * Implements a `KerasSalienceModel._pred_torch()` function based on the HF implementation in lit_nlp/examples/models/pretrained_lms.py * Provides a stub for `KerasSalienceModel._pred_jax()` with a detailed comment outlining the JAX idiosyncrasies that we need to adapt to in order to support this backend. PiperOrigin-RevId: 622966761
PiperOrigin-RevId: 622999169
PiperOrigin-RevId: 623027970
PiperOrigin-RevId: 623264456
PiperOrigin-RevId: 623274231
PiperOrigin-RevId: 623280819
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
RyanMullins
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.