docs: removes databases package recommendation #2940
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| You can use it with an asynchronous ORM, such as [GINO](https://python-gino.org/), | ||
| or use regular non-async endpoints, and integrate with [SQLAlchemy](https://www.sqlalchemy.org/). | ||
| You can use it with an asynchronous ORM, such as [GINO](https://python-gino.org/) or [SQLAlchemy](https://www.sqlalchemy.org/), or use regular non-async endpoints. |
|
|
||
| In this documentation we'll demonstrate how to integrate against [the `databases` package](https://github.com/encode/databases), | ||
| which provides SQLAlchemy core support against a range of different database drivers. | ||
| In this documentation we'll demonstrate how to integrate against [SQLAlchemy](https://www.sqlalchemy.org/). |
|
|
||
| Here's a complete example, that includes table definitions, configuring a `database.Database` | ||
| instance, and a couple of endpoints that interact with the database. | ||
| Here's a complete example, that includes table definitions, configuring a database connection, and a couple of endpoints that interact with the database. |
There was a problem hiding this comment.
keep database.Database under the bracket() right after the line- "configuring a database connection"
| from contextlib import asynccontextmanager | ||
| from typing import AsyncIterator | ||
|
|
||
| from sqlalchemy import MetaData, select |
There was a problem hiding this comment.
not all of these imports are necessary at the initial point if the user is not going to use these later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starts on closing out #1921
TODOs:
Checklist