feat: updated dynamic secret,secret import to support glob in environment #3748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
PR Summary
Added glob pattern support for environment matching in dynamic secrets and secret import permissions, enabling more flexible access control patterns.
- Permission schema updated in
backend/src/ee/services/permission/project-permission.tsto include$GLOBoperator for environment conditions - Security consideration: Ensure glob patterns are properly validated to prevent overly permissive access patterns
- Impact: Breaking change for any systems directly interfacing with permission schema (Terraform/API clients)
- Missing documentation: Need clarity on how customers will discover and use this new glob functionality
- Customer visibility: No documentation found in /docs folder for this feature
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
maidul98
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Fixes the missing glob operator in environment for dynamic secret and secret import
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets