+
Skip to content

allow updating pod_cidr_overprovision_config on node pools #15197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow updating pod_cidr_overprovision_config on node pools #15197

wants to merge 1 commit into from

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Sep 21, 2025 •
edited by zli82016
Loading

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added in-place update support for `network_config.pod_cidr_overprovision_config` field in `google_container_node_pool` resource

container: added in-place update support for `node_pool.network_config.pod_cidr_overprovision_config` field in `google_container_cluster` resource

I have limited ability to test this but looks correct according to docs

@DrFaust92
allow updating pod_cidr_overprovision_config on node pools
5aded9a 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92 DrFaust92 marked this pull request as ready for review September 21, 2025 16:32
@github-actions github-actions bot requested a review from zli82016 September 21, 2025 16:33
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 7 deletions(-))

zli82016
zli82016 requested changes Sep 22, 2025
View reviewed changes
mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.tmpl
services_ipv4_cidr_block = "10.2.0.0/16"
pod_cidr_overprovision_config {
disabled = true
disabled = %t
Copy link
Member

@zli82016 zli82016 Sep 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not for field node_pool.network_config.pod_cidr_overprovision_config in google_container_cluster.

Also, the update test should test updating pod_cidr_overprovision_config field, instead of pod_cidr_overprovision_config.disabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 thank for catching this, ill fix this

@zli82016
Copy link
Member

zli82016 commented Sep 22, 2025 •
edited
Loading

The field network_config.pod_cidr_overprovision_config is shared by google_container_node_pool resource and google_container_cluster resource. I modified the release notes a little bit.

Also, can you add the update test for network_config.pod_cidr_overprovision_config in google_container_node_pool resource ? Thanks.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 257
Passed tests: 202
Skipped tests: 11
Affected tests: 44

Click here to see the affected service packages
  • container

Action taken

Found 44 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_auto_ipam_config_enabled
  • TestAccContainerCluster_nodeAutoprovisioningDefaults
  • TestAccContainerCluster_privateRegistry
  • TestAccContainerCluster_withDeletionProtection
  • TestAccContainerCluster_withFleetConfig
  • TestAccContainerCluster_withIdentityServiceConfig
  • TestAccContainerCluster_withIntraNodeVisibility
  • TestAccContainerCluster_withMonitoringConfig
  • TestAccContainerCluster_withNodePoolResize
  • TestAccContainerCluster_withNodePoolUpdateVersion
  • TestAccContainerCluster_withSandboxConfig
  • TestAccContainerCluster_withTPUConfig
  • TestAccContainerCluster_withTpu
  • TestAccContainerCluster_with_PodCIDROverprovision
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_concurrent
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_secondaryBootDisks
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLegacyNodeConfigAndBootDiskUpdate
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withNodeConfigWithBootDiskConfig
  • TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeType
  • TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeTypeLegacy
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_auto_ipam_config_enabled [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults [Debug log]
TestAccContainerCluster_privateRegistry [Debug log]
TestAccContainerCluster_withDeletionProtection [Debug log]
TestAccContainerCluster_withFleetConfig [Debug log]
TestAccContainerCluster_withIntraNodeVisibility [Debug log]
TestAccContainerCluster_withMonitoringConfig [Debug log]
TestAccContainerCluster_withNodePoolResize [Debug log]
TestAccContainerCluster_withNodePoolUpdateVersion [Debug log]
TestAccContainerCluster_withSandboxConfig [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_concurrent [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLegacyNodeConfigAndBootDiskUpdate [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfig [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeType [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeTypeLegacy [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_withNodePoolResize [Error message] [Debug log]
TestAccContainerNodePool_concurrent [Error message] [Debug log]
TestAccContainerNodePool_resize [Error message] [Debug log]
TestAccContainerNodePool_withHugepageConfig [Error message] [Debug log]
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withIdentityServiceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerCluster_with_PodCIDROverprovision [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

@DrFaust92, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zli82016 zli82016 zli82016 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
service/container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @modular-magician @zli82016
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载