chore(modelarmor): enabled floor settings tests #5345
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @mihirvala-crestdata, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request re-enables a set of integration tests within the modelarmor module that were previously skipped. These tests, which cover various "floor settings" operations (get and update at project, organization, and folder levels), can now run as the underlying issue that caused them to be skipped has been fixed.
Highlights
- Test Re-enablement: I've re-enabled six previously skipped tests related to
modelarmorfloor settings. These includeTestGetProjectFloorSettings,TestGetOrganizationFloorSettings,TestGetFolderFloorSettings,TestUpdateFolderFloorSettings,TestUpdateOrganizationFloorSettings, andTestUpdateProjectFloorSettings. This was done because the blocking issueb/424365799has been resolved.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enables several system tests for floor settings, which is great. The changes correctly remove the t.Skip calls. My review focuses on ensuring the newly enabled tests are robust. I've identified a potential issue in the three Update... tests where cleanup logic may not execute on failure, potentially leading to state leakage and affecting other tests. I've provided details in the comments.
| @@ -1364,7 +1363,7 @@ func TestUpdateFolderFloorSettings(t *testing.T) { | |||
| // TestUpdateOrganizationFloorSettings tests updating floor settings for a specific organization. | |||
| // It ensures the output buffer includes a success message confirming the update. | |||
| func TestUpdateOrganizationFloorSettings(t *testing.T) { | |||
| t.Skip("TODO(b/424365799): Update this once the mentioned issue is resolved") | |||
|
|
|||
There was a problem hiding this comment.
nit: let's remove all the empty lines as well.
|
Tests are failing due to missing permissions. Ref: Logs Can someone help in granting following IAM permissions to the project/org/folder used in running these tests?
|
Description
Enabling floor settings as issue b/424365799 is fixed
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)