+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Oct 10, 2025

🚀 Description

Dropdown currently relies on some private stuff in Tag that's specific to Dropdown.

Dropdown, for example, has a requirement to present Tags different visually when Dropdown is readonly. Tag is also configured by Dropdown to show pencil icon when a selected Dropdown Option is editable.

I talked to Design. There are no other use cases for these Tag features outside Dropdown. So I've copied Tag into Dropdown and removed the Dropdown-specific stuff from Tag.

Additionally:

Minor

Tag no longer supports a --max-inline-size custom property. Dropdown, to our knowledge, was the only user of it and no longer uses it. If you have a use case for --max-inline-size, let us know.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Manual Testing

Dropdown

  1. Check out this branch.
  2. Navigate to Dropdown in Storybook.
  3. Set multiple.
  4. Select a few options.
  5. Verify a tag is shown for each selected option.
  6. Give the first selected option a long label.
  7. Resize the viewport.
  8. Verify tags truncate and move into overflow as needed.
  9. Remove a tag by clicking its "X" button.
  10. Verify the tag is removed and its corresponding option is deselected.
  11. Make a selected option editable.
  12. Verify the option's tag has a pencil icon.
  13. Verify that clicking the pencil icon closes Dropdown and results in an "edit" event.
  14. Verify that clicking a tag's label toggles Dropdown open and closed.
  15. Select every option.
  16. Use your keyboard to tab to each option's tag and press Enter or Space to remove each tag.
  17. Verify the tags are removed and their corresponding options are deselected.
  18. Also verify that focus correctly moved from one tag's removal button ("X") to the next or previous tag's removal button.

Tag

  1. Check out this branch.
  2. Navigate to Tag in Storybook.
  3. Verify Tag's visuals and functionality.

Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: a8c8e42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs changed the title Copy tag to dropdown Copy Tag into dropdown Oct 10, 2025
@clintcs clintcs force-pushed the copy-tag-to-dropdown branch from 918445e to 8f45f4b Compare October 10, 2025 14:47

#onComponentFocusOut(event: FocusEvent) {
const isTargetFocused =
const isStillFocused =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes an unpublished bug that was causing this test to fail.

@clintcs clintcs force-pushed the copy-tag-to-dropdown branch 2 times, most recently from 5030889 to a07333d Compare October 10, 2025 14:58
@clintcs clintcs changed the title Copy Tag into dropdown Copy Tag into Dropdown Oct 10, 2025
@clintcs clintcs force-pushed the copy-tag-to-dropdown branch 8 times, most recently from acfb312 to c8ab4d0 Compare October 10, 2025 16:25
@clintcs clintcs force-pushed the copy-tag-to-dropdown branch from c8ab4d0 to a8c8e42 Compare October 10, 2025 16:33
*
* @readonly
* @attr {string} [version]
*
Copy link
Collaborator Author

@clintcs clintcs Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler 👇

@clintcs clintcs marked this pull request as ready for review October 10, 2025 16:39
@clintcs clintcs added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit 63e4acd Oct 13, 2025
@clintcs clintcs deleted the copy-tag-to-dropdown branch October 13, 2025 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载