This repository was archived by the owner on Oct 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Copy Tag into Dropdown #1203
Merged
Merged
Copy Tag into Dropdown #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a8c8e42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
918445e
to
8f45f4b
Compare
clintcs
commented
Oct 10, 2025
|
||
#onComponentFocusOut(event: FocusEvent) { | ||
const isTargetFocused = | ||
const isStillFocused = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes an unpublished bug that was causing this test to fail.
5030889
to
a07333d
Compare
acfb312
to
c8ab4d0
Compare
c8ab4d0
to
a8c8e42
Compare
clintcs
commented
Oct 10, 2025
* | ||
* @readonly | ||
* @attr {string} [version] | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much simpler 👇
ynotdraw
approved these changes
Oct 13, 2025
danwenzel
approved these changes
Oct 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Dropdown currently relies on some private stuff in Tag that's specific to Dropdown.
Dropdown, for example, has a requirement to present Tags different visually when Dropdown is
readonly
. Tag is also configured by Dropdown to show pencil icon when a selected Dropdown Option iseditable
.I talked to Design. There are no other use cases for these Tag features outside Dropdown. So I've copied Tag into Dropdown and removed the Dropdown-specific stuff from Tag.
Additionally:
📋 Checklist
🔬 Manual Testing
Dropdown
multiple
.editable
.Tag