Remove remaining Core stuff from Dropdown and Dropdown Option #1204
Conversation
|
5170b09 to
7110038
Compare
| * @default undefined | ||
| */ | ||
| @property() | ||
| @property({ reflect: true }) |
There was a problem hiding this comment.
Forgot to reflect split everywhere. I'll follow up and add reflect: true to our other components.
f777a02 to
d91511c
Compare
| } | ||
|
|
||
| set split(split: 'left' | 'middle' | 'right' | undefined) { | ||
| this.#split = split; |
There was a problem hiding this comment.
Switched the order for coverage purposes. Ignores (c8 ignore start) don't work as reliably in Web Test Runner as they do Playwright.
d91511c to
70e6a2b
Compare
|
Just learned that Dropdown's new owner has a |
| } | ||
| .checked-icon-container { | ||
| --private-size: 1rem; |
ba0d66c ✅ |
🚀 Description
@finalandassertSlot().versionattribute: a Core-ism that requires some Vite configuration.implements FormControlfrom both components' classes.A few things remain, which I left in case Dropdown's new owners want to continue to use them:
Both components' use of
uniqueId().Dropdown's use of
onResize(), which is a convenient way to attach resize observers.Uses of
requestIdleCallback()in tests.requestIdleCallback()should probably be copied along with Dropdown so its tests remain relatively stable.Uses of
click()andhover()in tests. Those functions are a nice abstraction for testing clicks and hovers as a user would perform them.mouse.ts, where they're exported from, should probably be copied over.Dropdown's visual tests, which run in Playwright and may or may not be desirable to copy over. Same for Dropdown's accessibility tests.
Uses of Shoelace's
Localize.Other than that, Dropdown's new owners will need to:
import './checkbox.js'→import '@crowdstrike/glide-core/checkbox.js').<glide-core-example-icon>references in Storybook with something else.expectWindowError()call indropdown.test.basics.ts.📋 Checklist
🔬 Manual Testing
Feel free to do a spotcheck locally of Dropdown's functionality, which I've done. But its tests should largely have us covered.