+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Remove test skips #1173

Closed
wants to merge 1 commit into from
Closed

Remove test skips #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/accordion.test.keyboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,7 @@ test(
test(
'can be opened via Space',
{ tag: '@keyboard' },
async ({ browserName, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page }) => {
await mount(
() =>
html`<glide-core-accordion label="Label">
Expand Down
14 changes: 2 additions & 12 deletions src/accordion.test.miscellaneous.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,7 @@ test('defines itself', { tag: '@miscellaneous' }, async ({ mount, page }) => {
test(
'can be opened programatically',
{ tag: '@miscellaneous' },
async ({ browserName, setProperty, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ setProperty, mount, page }) => {
await mount(
() =>
html`<glide-core-accordion label="Label">
Expand Down Expand Up @@ -49,12 +44,7 @@ test(
test(
'can be closed programatically',
{ tag: '@miscellaneous' },
async ({ browserName, setProperty, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ setProperty, mount, page }) => {
await mount(
() =>
html`<glide-core-accordion label="Label" open>
Expand Down
42 changes: 6 additions & 36 deletions src/accordion.test.mouse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,7 @@ import { expect, test } from './playwright/test.js';
test(
'can be opened via mouse when animated',
{ tag: '@mouse' },
async ({ browserName, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page }) => {
await mount(
() =>
html`<glide-core-accordion label="Label">
Expand Down Expand Up @@ -38,12 +33,7 @@ test(
test(
'can be opened via mouse when not animated',
{ tag: '@mouse' },
async ({ browserName, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page }) => {
await page.emulateMedia({ reducedMotion: 'reduce' });

await mount(
Expand Down Expand Up @@ -74,12 +64,7 @@ test(
test(
'can be opened via `click()`',
{ tag: '@mouse' },
async ({ browserName, callMethod, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ callMethod, mount, page }) => {
await mount(
() =>
html`<glide-core-accordion label="Label">
Expand Down Expand Up @@ -108,12 +93,7 @@ test(
test(
'can be closed via mouse when animated',
{ tag: '@mouse' },
async ({ browserName, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page }) => {
await mount(
() =>
html`<glide-core-accordion label="Label" open>
Expand Down Expand Up @@ -142,12 +122,7 @@ test(
test(
'can be closed mouse when not animated',
{ tag: '@mouse' },
async ({ browserName, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page }) => {
await page.emulateMedia({ reducedMotion: 'reduce' });

await mount(
Expand Down Expand Up @@ -178,12 +153,7 @@ test(
test(
'can be closed via `click()`',
{ tag: '@mouse' },
async ({ browserName, callMethod, mount, page }) => {
test.skip(
browserName === 'webkit',
'"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ callMethod, mount, page }) => {
await mount(
() =>
html`<glide-core-accordion label="Label" open>
Expand Down
28 changes: 4 additions & 24 deletions src/drawer.test.miscellaneous.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@ test('defines itself', { tag: '@miscellaneous' }, async ({ mount, page }) => {
test(
'can be opened',
{ tag: '@miscellaneous' },
async ({ browserName, mount, page, setProperty }) => {
test.skip(
browserName === 'webkit',
'"toggle" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page, setProperty }) => {
await mount(
() => html`<glide-core-drawer label="Label">Content</glide-core-drawer>`,
);
Expand All @@ -45,12 +40,7 @@ test(
test(
'can be closed',
{ tag: '@miscellaneous' },
async ({ browserName, mount, page, setProperty }) => {
test.skip(
browserName === 'webkit',
'"toggle" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page, setProperty }) => {
await mount(
() =>
html`<glide-core-drawer label="Label" open>Content</glide-core-drawer>`,
Expand All @@ -77,12 +67,7 @@ test(
test(
'does not dispatch a "toggle" event when already open and opened programmatically',
{ tag: '@miscellaneous' },
async ({ browserName, mount, page, setProperty }) => {
test.skip(
browserName === 'webkit',
'"toggle" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page, setProperty }) => {
await mount(
() =>
html`<glide-core-drawer label="Label" open>Content</glide-core-drawer>`,
Expand All @@ -106,12 +91,7 @@ test(
test(
'does not dispatch a "toggle" event when already closed and closed programmatically',
{ tag: '@miscellaneous' },
async ({ browserName, mount, page, setProperty }) => {
test.skip(
browserName === 'webkit',
'"toggle" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).',
);

async ({ mount, page, setProperty }) => {
await mount(
() => html`<glide-core-drawer label="Label">Content</glide-core-drawer>`,
);
Expand Down
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载