+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Support Option value changes in Select #1169

Merged
merged 2 commits into from
Sep 22, 2025
Merged

Support Option value changes in Select #1169

merged 2 commits into from
Sep 22, 2025

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Sep 19, 2025 •
edited
Loading

🚀 Description

Patch

Select now updates its value attribute when the value attribute of a selected Option changes.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Manual Testing

The tests I added should have us covered.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: fb8f631

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs changed the title Support option value changes in select Support Option value changes in Select Sep 19, 2025
@clintcs clintcs changed the title Support Option value changes in Select Support Option value changes in Select Sep 19, 2025
@clintcs clintcs force-pushed the support-option-value-changes-in-select branch from e285cd7 to 04f0bf5 Compare September 19, 2025 16:52
@clintcs clintcs force-pushed the support-option-value-changes-in-select branch from 04f0bf5 to e63451b Compare September 19, 2025 16:53
@clintcs clintcs marked this pull request as ready for review September 19, 2025 17:01
clintcs
clintcs commented Sep 19, 2025
View reviewed changes
@clintcs clintcs added this pull request to the merge queue Sep 19, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2025
@clintcs
Support Option value changes in Select (#1169)
42bfd9c
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2025
@clintcs clintcs added this pull request to the merge queue Sep 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2025
@clintcs clintcs added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 22, 2025
@clintcs clintcs added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 1ca7ef2 Sep 22, 2025
21 checks passed
@clintcs clintcs deleted the support-option-value-changes-in-select branch September 22, 2025 15:44
@github-actions github-actions bot mentioned this pull request Sep 22, 2025
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danwenzel danwenzel Awaiting requested review from danwenzel danwenzel is a code owner

1 more reviewer

@ynotdraw ynotdraw ynotdraw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clintcs @ynotdraw
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载