Add Select Options slot support #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b672a6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
18faa9c to
e789f71
Compare
e789f71 to
ca15de9
Compare
clintcs
commented
Sep 19, 2025
| } | ||
| }, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
I debated an abstraction for cases like this. But it's pretty simple as is. So I don't know what would be abstracted. We also only have a few instances of tests that test a component in another component.
clintcs
commented
Sep 19, 2025
| return firstAssignedElement instanceof Options | ||
| ? firstAssignedElement | ||
| : null; | ||
| ?.find((element): element is Options => element instanceof Options); |
There was a problem hiding this comment.
Same logic as Menu here and above.
ce63c93 to
732140e
Compare
732140e to
b672a6b
Compare
ynotdraw
approved these changes
Sep 19, 2025
| } | ||
| }, | ||
| ); | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
📋 Checklist
🔬 Manual Testing
A tough one to test manually. But you're welcome to manipulate Select's story locally.