Migrate Toggle's tests #1164
Migrate Toggle's tests #1164
Conversation
|
| type: 'toggle', | ||
| bubbles: true, | ||
| cancelable: false, | ||
| composed: true, |
There was a problem hiding this comment.
No need to assert stuff like this with a not.toDispatchEvents() assertion.
| const tooltip = page.getByTestId('tooltip'); | ||
|
|
||
| await button.hover(); | ||
| await expect(host).toDispatchEvents( |
acf013e to
fc7c30e
Compare
fc7c30e to
985eb9c
Compare
| test.skip( | ||
| browserName === 'webkit', | ||
| '"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).', | ||
| ); |
There was a problem hiding this comment.
Just a test to see if the Webkit 26 release candidate fixed the issue. No failures yet. I'll keep an eye on CI and unskip the other tests if this test remains stable.
There was a problem hiding this comment.
Oh man, that'd be awesome if so!
| ); | ||
|
|
||
| const host = page.locator('glide-core-toggle'); | ||
| const switch$ = page.getByRole('switch'); |
There was a problem hiding this comment.
Reserved word. Happy to use whatever naming convention.
There was a problem hiding this comment.
Ah. I'm good with this 👍
| test.skip( | ||
| browserName === 'webkit', | ||
| '"finish" is dispatched inconsistently in CI. Or perhaps on Ubuntu. Try removing this when Webkit 26 is stable (TODO).', | ||
| ); |
There was a problem hiding this comment.
Oh man, that'd be awesome if so!
| ); | ||
|
|
||
| const host = page.locator('glide-core-toggle'); | ||
| const switch$ = page.getByRole('switch'); |
There was a problem hiding this comment.
Ah. I'm good with this 👍
🚀 Description
N/A
📋 Checklist
🔬 Manual Testing
N/A