Linter made me do it.

loading=${true} would also work, but we don't need to test loading=${false}, as it's redundant with disabled=${false} above.

Did the same for the visual tests. It's probably not ideal, but it beats running an almost identical visual test for every variant with both themes and for every story.

With the addition of loading, it complicated our visual tests quite a bit, as I wanted to test each variant when loading. The existing tests had variant tests mixed in across different states. And while I could have added a describe() block and then tested each variant in there, I also wanted to ensure the focus and hover states when loading were correct. So that complicated things quite a bit.

What I ended up doing here is looping over each Button variant, as you can see starting on line 10. I then had to move things around a bit to ensure we maintain the existing coverage, while also including the loading additions.

This way, we can test each variant and other potential visual states - whether it's attributes, focus states, hover states, or anything else. I think this will serve us well from now on.

The diff is gnarly, so it may be best to view the file directly instead.

Worth mentioning that loading will also prevent click events?

Or maybe, more generally, that loading effectively disables Button.

eh?

2fe3e17 ✅