+
Skip to content

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Sep 15, 2025

🚀 Description

Migrated Popover's tests. Also fixed some bugs I came across:

Patch

  • Popover no longer dispatches a "toggle" event when disabled and opened programmatically.
  • Popover no longer sets its open attribute when disabled and its target is clicked.
  • Popover now sets aria-expanded="false" on its target both when initially open but disabled and when initially closed and enabled.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Manual Testing

N/A

Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: c2a0a9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs force-pushed the migrate-popover-tests branch 2 times, most recently from 6d69b62 to d6f6e94 Compare September 16, 2025 14:52
@clintcs clintcs force-pushed the migrate-popover-tests branch from d6f6e94 to c2a0a9d Compare September 16, 2025 15:03
@clintcs clintcs marked this pull request as ready for review September 16, 2025 15:12
@clintcs clintcs added this pull request to the merge queue Sep 16, 2025
Merged via the queue into main with commit 7f08c34 Sep 16, 2025
22 checks passed
@clintcs clintcs deleted the migrate-popover-tests branch September 16, 2025 16:22
@github-actions github-actions bot mentioned this pull request Sep 16, 2025
clintcs added a commit that referenced this pull request Sep 17, 2025
clintcs added a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载