Add size="large" to Icon Button #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f47560 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ynotdraw
commented
Sep 15, 2025
There was a problem hiding this comment.
Did the same thing I did for Button, looping over variant and testing. Unfortunately this muddies the test report, but going forward it should be better.
| await expect(page).toHaveScreenshot( | ||
| `${test.titlePath.join('.')}.png`, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Figured this would be a good thing to test, as we have active states for our buttons and testing those when not disabled is arguably more important than testing them being disabled. Let me know if you feel otherwise.
clintcs
approved these changes
Sep 15, 2025
danwenzel
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Add a
sizeattribute to Icon Button to allow forsize="large".📋 Checklist
🔬 Manual Testing
Visual tests should be enough, but to test some design-specific asks: