+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Sep 8, 2025

🚀 Description

Patch

  • Multiselect Dropdown's tags now have a slightly longer minimum width.
  • Tag now has a --max-inline-size CSS custom property.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Manual Testing

  1. Navigate to Dropdown in Storybook.
  2. Add the multiple and filterable attributes.
  3. Give a Dropdown Option a long label.
  4. Resize your viewport to a small size.
  5. Verify Dropdown's tags truncate down to a few characters instead of a single character.

Copy link

changeset-bot bot commented Sep 8, 2025

🦋 Changeset detected

Latest commit: 7883919

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs force-pushed the increase-dropdown-tag-minimum-width branch 2 times, most recently from ddc71ea to a07378b Compare September 8, 2025 19:42
@clintcs clintcs marked this pull request as ready for review September 8, 2025 19:42
@clintcs clintcs force-pushed the increase-dropdown-tag-minimum-width branch from a07378b to bd9d8b1 Compare September 8, 2025 19:43
data-id=${option.id}
label=${ifDefined(option.label)}
removable
style="--max-inline-size: none"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, we'd end up with this because tags don't fill their container by default:


image

@clintcs clintcs enabled auto-merge September 9, 2025 12:19
@clintcs clintcs added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit dbbbf09 Sep 9, 2025
22 checks passed
@clintcs clintcs deleted the increase-dropdown-tag-minimum-width branch September 9, 2025 12:49
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载