+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

ynotdraw
Copy link
Collaborator

@ynotdraw ynotdraw commented Sep 5, 2025

🚀 Description

Update Menu's isOwnTarget to account for cases like a Tooltip target.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Manual Testing

Tests should be enough, but generally poke around Menu and make sure nothing is broken. We don't test combining multiple components, as the permutations would be massive.

If you want to test locally, add this to the Menu story as the target:

<glide-core-tooltip label="Label" slot="target">
  <glide-core-icon-button label="Toggle" slot="target">
    <glide-core-example-icon name="three-dots"></glide-core-example-icon>
  </glide-core-icon-button>
</glide-core-tooltip>

@ynotdraw ynotdraw self-assigned this Sep 5, 2025
Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: 6167c06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ynotdraw ynotdraw marked this pull request as ready for review September 5, 2025 13:51
@ynotdraw ynotdraw added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 6fe1c44 Sep 5, 2025
22 checks passed
@ynotdraw ynotdraw deleted the menu-fix branch September 5, 2025 16:37
@github-actions github-actions bot mentioned this pull request Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载