Add Select multiple attribute
#1136
Conversation
🦋 Changeset detectedLatest commit: e622ea2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4f0fb49 to
546b1b8
Compare
| import { html } from 'lit'; | ||
| import { expect, test } from './playwright/test.js'; | ||
|
|
||
| test( |
There was a problem hiding this comment.
Just moved single-select specific tests from select.test.keyboard.ts.
| import { html } from 'lit'; | ||
| import { expect, test } from './playwright/test.js'; | ||
|
|
||
| test( |
There was a problem hiding this comment.
Just moved single-select specific tests from select.test.miscellaneous.ts.
| const options = page.getByRole('option'); | ||
|
|
||
| // eslint-disable-next-line playwright/no-force-option | ||
| await options.first().click({ force: true }); |
There was a problem hiding this comment.
Another legitimate use of { force: true }.
| await expect(page).toHaveScreenshot( | ||
| `${test.titlePath.join('.')}.png`, | ||
| ); | ||
| test.describe('multiple=${false}', () => { |
There was a problem hiding this comment.
Wrapped a few existing tests in test.describe('multiple=${false}' and test.describe('multiple=${true}'.
c7942cf to
53f827e
Compare
| }); | ||
|
|
||
| test( | ||
| 'sets `aria-multiselectable` on its target when multiselect initially', |
| <glide-core-options> | ||
| <glide-core-option label="One" value="one"></glide-core-option> | ||
| <glide-core-option label="Two" value="two"></glide-core-option> | ||
| <glide-core-option label="One" value="one"></glide-core-option> |
There was a problem hiding this comment.
Assume the duplicate value is intentional, eh?
There was a problem hiding this comment.
Aye. Because multiple options can have the same value.
53f827e to
e622ea2
Compare
|
Rebased to resolve the changeset conflict. |
🚀 Description
📋 Checklist
🔬 Manual Testing
multipleattribute.