+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Improve Toast accessibility #1117

Merged
merged 1 commit into from
Aug 28, 2025
Merged

Improve Toast accessibility #1117

merged 1 commit into from
Aug 28, 2025

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Aug 28, 2025 •
edited
Loading

🚀 Description

Patch

Toast's label and variant are no longer announced twice by screenreaders.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Manual Testing

  1. Navigate to Toast in Storybook.
  2. Turn on VoiceOver.
  3. Add a Toast.
  4. Verify the Toast's label and variant are only announced once.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c238973

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs force-pushed the improve-toast-accessibility branch from b99dd4e to c238973 Compare August 28, 2025 18:55
@clintcs clintcs marked this pull request as ready for review August 28, 2025 19:07
@clintcs clintcs added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit cd0fd8a Aug 28, 2025
64 of 66 checks passed
@clintcs clintcs deleted the improve-toast-accessibility branch August 28, 2025 19:54
@github-actions github-actions bot mentioned this pull request Aug 28, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danwenzel danwenzel Awaiting requested review from danwenzel danwenzel is a code owner

1 more reviewer

@ynotdraw ynotdraw ynotdraw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clintcs @ynotdraw
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载