+
Skip to content

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Aug 28, 2025

🚀 Description

Minor

Popover now requires its default slot content to be wrapped in a Popover Container. The reason for the change is so Popover's target and its default slot content can be associated with one another via ARIA attributes, improving accessibility.

<glide-core-popover>
  <button slot="target">Target</button>

  <glide-core-popover-container>Content</glide-core-popover-container
</glide-core-popover>

Patch

Popover's content is now announced by screenreaders when Popover is opened.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Manual Testing

  1. Navigate to Popover in Storybook.
  2. Turn on VoiceOver.
  3. Tab to Popover's target.
  4. Verify Popover's content is not announced.
  5. Press Space to open Popover.
  6. Verify Popover's content is announced.
  7. Press Space to close Popover.
  8. Verify Popover's content is not announced.

Copy link

changeset-bot bot commented Aug 28, 2025

🦋 Changeset detected

Latest commit: aa02842

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs force-pushed the improve-popover-accessibility branch 7 times, most recently from d036e10 to 01d8b9f Compare August 28, 2025 17:42
@clintcs clintcs marked this pull request as ready for review August 28, 2025 17:43
@clintcs clintcs force-pushed the improve-popover-accessibility branch from 01d8b9f to d9ef634 Compare August 28, 2025 17:44
@clintcs clintcs enabled auto-merge August 28, 2025 22:17
@clintcs clintcs disabled auto-merge August 28, 2025 22:18
@clintcs clintcs force-pushed the improve-popover-accessibility branch from aee85f6 to 6c6e509 Compare August 29, 2025 14:38
@clintcs
Copy link
Collaborator Author

clintcs commented Aug 29, 2025

Pushed a commit with a small improvement.

@clintcs clintcs force-pushed the improve-popover-accessibility branch from efc90bc to aa02842 Compare September 18, 2025 12:22
@clintcs
Copy link
Collaborator Author

clintcs commented Sep 18, 2025

Pushed a commit to resolve merge conflicts and to migrate the new tests to Playwright.

@ynotdraw
Copy link
Collaborator

@clintcs changes look good to me!

@clintcs clintcs added this pull request to the merge queue Sep 18, 2025
Merged via the queue into main with commit 3ef1093 Sep 18, 2025
25 checks passed
@clintcs clintcs deleted the improve-popover-accessibility branch September 18, 2025 16:37
@github-actions github-actions bot mentioned this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载