This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Dropdown accessibility improvement #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bdccd49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d834796 to
54e37b1
Compare
clintcs
commented
Aug 27, 2025
| await page.getByRole('combobox').fill('add'); | ||
| await page.getByRole('combobox').focus(); | ||
|
|
||
| await expect(page.locator('glide-core-dropdown')).toMatchAriaSnapshot(` |
There was a problem hiding this comment.
"required" doesn't show up in the accessibility tree. But it is announced by VoiceOver.
54e37b1 to
bdccd49
Compare
clintcs
commented
Aug 27, 2025
| .locator('glide-core-dropdown') | ||
| .evaluate<void, Dropdown>((element) => { | ||
| element.multiple = true; | ||
| element.multiple = false; |
There was a problem hiding this comment.
This is the 'select-all' test inside the 'multiple=${false}' describe block. So multiple should be false.
clintcs
commented
Aug 27, 2025
| - tooltip "Tooltip" | ||
| - text: Label | ||
| - button "Label" | ||
| `); |
There was a problem hiding this comment.
I wish Playwright would indent these right.
ynotdraw
approved these changes
Aug 27, 2025
danwenzel
approved these changes
Aug 27, 2025
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
📋 Checklist
🔬 Manual Testing
You know what to do!