This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Inline Alert accessibility improvements #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02866b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clintcs
commented
Aug 26, 2025
| @final | ||
| export default class ButtonGroupButton extends LitElement { | ||
| /* c8 ignore start */ | ||
| /* c8 ignore start */ |
2f93045 to
5f89bb0
Compare
danwenzel
approved these changes
Aug 26, 2025
ynotdraw
reviewed
Aug 26, 2025
src/inline-alert.ts
Outdated
| override render() { | ||
| return html` | ||
| <div | ||
| aria-label=${this.variant} |
There was a problem hiding this comment.
Should we translate this for screen reader announcements?
There was a problem hiding this comment.
We definitely should. Good catch.
b2c0f5d to
f7ff2cd
Compare
ynotdraw
approved these changes
Aug 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
📋 Checklist
🔬 Manual Testing
You know what to do!