This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Expose Option and Options' private events #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3a10a89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5c66818 to
b9efb1e
Compare
b9efb1e to
3a10a89
Compare
clintcs
commented
Aug 18, 2025
| summary: 'method', | ||
| detail: ` | ||
| // "slotchange" is useful when you are abstracting over Menu to add functionality to it. See Select's | ||
| // use of this event for an example. |
There was a problem hiding this comment.
Select doesn't exist yet. But it will shortly!
ynotdraw
approved these changes
Aug 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
People probably won't need these events because the hope, at least, is that either Menu or Select will work for everyone. But anyone, not just us, should be able to build something like Select on top of Menu. And to do that you need to listen for some or all of these events.
📋 Checklist
🔬 Manual Testing
The tests I added should have us covered.