This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Activate Menu's active Option before opening Menu #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 412b02c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clintcs
commented
Aug 15, 2025
| // But two open sub-Menus doesn't make sense. So Menu will close one of them in | ||
| // `firstUpdated()`. And it does that by setting `open` to `false`, which results | ||
| // in a `#hide()` call. So `#hide()` will be called immediately after `#show()`. | ||
| await this.#activeOption?.updateComplete; |
There was a problem hiding this comment.
Thanks for the comments as well! 🎉
cbd1e24 to
c93f1c1
Compare
clintcs
commented
Aug 18, 2025
| // This is a test to see if disabling Hot Module Reloading eliminates the Vite | ||
| // cache misses we've been seeing in CI with Playwright tests. We'll need to keep | ||
| // this in place for a while to see if it solves the problem. | ||
| noDiscovery: Boolean(process.env.CI), |
There was a problem hiding this comment.
1d354ed to
46822b9
Compare
46822b9 to
412b02c
Compare
ynotdraw
approved these changes
Aug 18, 2025
| // But two open sub-Menus doesn't make sense. So Menu will close one of them in | ||
| // `firstUpdated()`. And it does that by setting `open` to `false`, which results | ||
| // in a `#hide()` call. So `#hide()` will be called immediately after `#show()`. | ||
| await this.#activeOption?.updateComplete; |
There was a problem hiding this comment.
Thanks for the comments as well! 🎉
clintcs
commented
Aug 18, 2025
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: storybook | ||
| path: ./dist/storybook |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
📋 Checklist
🔬 Manual Testing