Add overflow handling and text truncation to Button #1053
Conversation
🦋 Changeset detectedLatest commit: 8e275ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0871574 to
1286ae8
Compare
| .label { | ||
| min-inline-size: 3ch; | ||
| overflow: hidden; |
There was a problem hiding this comment.
You'll notice some changes in the visual test report. I tracked it down to this line. For some reason, adding overflow: hidden causes a slight visual shift in CI, but not in a real browser. 🤔
Font smoothing/antialiasing thing in Linux maybe? That's about all I can think of.
| } | ||
| .label { | ||
| min-inline-size: 3ch; |
There was a problem hiding this comment.
Happy to pull this out if we don't think it should be there for Button.
| '@crowdstrike/glide-core': patch | ||
| --- | ||
|
|
||
| Button now shows an ellipsis when truncated. |
There was a problem hiding this comment.
Does it though? Or does getting an ellipsis to show also require styles from consumers?
There was a problem hiding this comment.
Doh, my apologies. Forgot to update this. Coming right up!
There was a problem hiding this comment.
I would have forgotten too 😆
1286ae8 to
8e275ee
Compare
🚀 Description
Add overflow handling and text truncation to Button
📋 Checklist
🔬 Testing
N/A