+
Skip to content

Conversation

ynotdraw
Copy link
Collaborator

@ynotdraw ynotdraw commented Jul 28, 2025

🚀 Description

Dropdown, Input, and Textarea have a more prominent focus style with an added box shadow.

📋 Checklist

  • I have followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have added or updated Storybook stories.
  • I have localized new strings.
  • I have followed the ARIA Authoring Practices Guide or met with the Accessibility Team.
  • I have included a changeset.
  • I have scheduled a design review.
  • I have reviewed the Storybook and Visual Test Report links below.

🔬 Testing

Visual tests should be enough.

@ynotdraw ynotdraw self-assigned this Jul 28, 2025
Copy link

changeset-bot bot commented Jul 28, 2025

🦋 Changeset detected

Latest commit: ae27567

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ynotdraw ynotdraw force-pushed the focus-styles branch 2 times, most recently from 213130b to 18b1e56 Compare July 29, 2025 18:40
.error {
border-color: var(--glide-core-color-advisory-stroke-error-primary);
}
Copy link
Collaborator Author

@ynotdraw ynotdraw Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .error class below has a lower specificity than &.quiet:not(.multiple), so the border-color set above would "win".

Explicitly adding this ensures it's applied when quiet and in the error state.

An alternative is to remove this and add border-color: var(--glide-core-color-advisory-stroke-error-primary); above line 133 below.

Open to other suggestions on cleanup/organization.

@ynotdraw ynotdraw marked this pull request as ready for review July 30, 2025 14:38
@clintcs
Copy link
Collaborator

clintcs commented Jul 30, 2025

Nice improvements.

@ynotdraw ynotdraw added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit 4abf4a5 Jul 30, 2025
111 of 116 checks passed
@ynotdraw ynotdraw deleted the focus-styles branch July 30, 2025 21:28
@github-actions github-actions bot mentioned this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载