This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Support preventing Popover from opening #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cafc326 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
32b4e41 to
3460e7e
Compare
|
Another one-off Menu diff in the visual test report. I believe this is the second time. |
Going to force another build. Tell me how you feel. But I'm okay with the occasional false positive if that's the cost of not having any false negatives. Because I'd rather have us have to acknowledge a diff rather than not be aware of one and having a bug slip through. |
3460e7e to
cafc326
Compare
ynotdraw
approved these changes
Jul 25, 2025
danwenzel
approved these changes
Jul 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
For its use in Menu, I recently added support to Tooltip for preventing Tooltip from opening and closing when consumers cancel "mouseover" and "mouseout" events on its target.
Not every component needs to have this feature. But Tooltip and Popover are very similar. So I thought I would bring the feature to Popover.
📋 Checklist
🔬 Testing
openattribute totrue.