fix(server/vehicle): use correct export for vehicle getters and add missing TS export #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. The addition of However your change to
|
|
Okay, think I got it. I'll implement these changes now. |
|
Should be good to go 👍🏻 |
FjamZoo
previously approved these changes
May 9, 2025
|
will wait for @antond15 to double check before merging |
antond15
requested changes
May 12, 2025
antond15
requested changes
May 12, 2025
|
All done :) Thank you for spotting these! |
FjamZoo
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an oversight that mostly affects TypeScript users. Currently, the only way to get a vehicle using its entity ID in TypeScript is through
GetVehicle. However, that function uses an export that does not exist, at least not anymore.In lua, users are able to use the function
Ox.GetVehicleFromEntity, which works as it should. In TS, there is no function under that name.This PR aims to fix this problem by adding the
GetVehicleFromEntityfunction to TypeScript and using the correct exports inGetVehiclefunctions, which are only kept because, if they were removed, it would break a lot of scripts no matter the environment.I am however going to need a say from maintainers on whether if it is a good idea to keep the GetVehicle function or remove the GetVehicleFromEntity function and keep the first one.
Fixes #5.