Add Sesame TTS Integration for Swift Audio Package #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR run is failing due to metal toolchain issue |
lucasnewman
reviewed
Sep 5, 2025
|
Generally looks good! I noticed your xcuserdata/ directories made it in -- it's best to remove those (you can add a .gitignore rule for it if you want). |
…tries to .gitignore
- Removed problematic mlx-swift-audio package dependency from Xcode project - Added proper MLX package dependencies (MLX, MLXNN, MLXRandom, MLXLMCommon, MLXLLM, Transformers) - Updated workspace configuration to use parent directory - Modified SesameSession.swift to support optional audio playback Note: Swift Package Manager builds successfully, but Xcode has issues resolving MLX dependencies
- Removed explicit mlx-swift and swift-transformers dependencies from Xcode - Keep only mlx-swift-examples which brings in both as transitive dependencies - This matches the Package.swift structure and avoids duplication Note: Xcode still has MLX dependency resolution issues, but Swift Package Manager works correctly
- Removed duplicate mlx-swift and swift-transformers dependencies - Keep only mlx-swift-examples which provides both as transitive dependencies - Updated package version to upToNextMajorVersion with minimumVersion 2.25.7 - Xcode project now builds successfully ✅ Before: mlx-swift + mlx-swift-examples + swift-transformers (redundant) After: mlx-swift-examples (includes mlx-swift + swift-transformers)
lucasnewman
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Sesame TTS integration to mlx-swift-audio package.
Components
Changes
Test Plan
Video: https://x.com/rudrankriyam/status/1963537827544580607