Fix make install-doc to fail if any doc fails to build.
#799
Conversation
Previously it would only fail if the last doc (BH_ref_guide) failed to build. So if the last doc built successfully but any of the others didn't, the build would still succeed as a whole and lead to missing docs in the final package.
|
I maintain a package of BlueSpec for OpenSUSE which had this problem. I had added the various LaTeX dependencies based on trying to build and watching what it complained was missing when it failed. Once it built successfully I thought I was done, but later I noticed that the package only had BH and BSV guides, and the user_guide and library_ref_guide were missing. I tracked the problem down to this Makefile loop not propagating the failure from individual submake invocations, so I had ended up only adding the deps needed for BH and BSV guides, and missed some deps that were only needed for user_guide and library_ref_guide. |
|
(The CI failure is a transient HTTP 500 error from fetching a dependency from ghcr.io, unrelated to this change.) |
|
Thank you for the fix. Sorry that you ran into this! I'll accept the PR, although I think in the long run it might be best to not have a for-loop at all and just have separate targets, so that the build can be done in parallel. |
Previously it would only fail if the last doc (BH_ref_guide) failed to build. So if the last doc built successfully but any of the others didn't, the build would still succeed as a whole and lead to missing docs in the final package.