Multilingual support #1084
Merged
Multilingual support #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not use Russian word for Joker for now.
rewtd
approved these changes
Feb 26, 2025
| @@ -433,14 +433,16 @@ suits: | |||
| id: "JOA" | |||
| value: "A" | |||
| url: "https://cornucopia.owasp.org/cards/JOA" | |||
| card: "Джокер" | |||
| #card: "Джокер" | |||
There was a problem hiding this comment.
Those are nearly the same length: Джокер (6 characters) and Joker (5 characters). Does the one character make the difference?
There was a problem hiding this comment.
Yes, the font makes the characters twice as long.
Stuw
added a commit
to Stuw/cornucopia-ru
that referenced
this pull request
Mar 12, 2025
Do not use Russian word for Joker, for now, due to it's size, to ensure the value of the card doesn't disappear. See OWASP#1084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.