+
Skip to content

Conversation

rven
Copy link
Contributor

@rven rven commented Sep 22, 2025

No description provided.

legalsylvain and others added 30 commits September 22, 2025 13:49
Optimize validation
Add logger to apply patch
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-module_change_auto_install
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_change_auto_install/
@rven rven changed the title 19.0 mig module change auto install [19.0] mig module change auto install Sep 22, 2025
@rven rven force-pushed the 19.0-mig-module_change_auto_install branch from 4181c12 to a207f3c Compare September 22, 2025 14:19
@rven rven changed the title [19.0] mig module change auto install [19.0][MIG] module_change_auto_install: Migration to 19.0 Sep 22, 2025
@rven rven marked this pull request as draft September 22, 2025 14:27
@legalsylvain
Copy link
Contributor

Hi. It looks like something is broken in the V19 CI.

https://github.com/OCA/server-tools/actions/runs/17918299803/job/50946259471?pr=3384#step:4:169

 could not obtain odoo.addons.__path__ using python
not found in addons path: base
Aborted.

other V19 PR have the same problem. (https://github.com/OCA/server-tools/actions/runs/17910628074/job/50921155714?pr=3382)

waiting for the fix.

@rven rven force-pushed the 19.0-mig-module_change_auto_install branch 2 times, most recently from 59c2dad to 6c05335 Compare September 25, 2025 05:54
@rven rven marked this pull request as ready for review September 25, 2025 05:58
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
Thanks a lot for porting this module, adapting the code, and adding tests !

@rven rven marked this pull request as draft September 25, 2025 10:29
@rven
Copy link
Contributor Author

rven commented Sep 25, 2025

I'm still testing this change, doesn't seem to work right now

@rven rven force-pushed the 19.0-mig-module_change_auto_install branch from 6c05335 to 3522918 Compare September 25, 2025 12:55
@rven
Copy link
Contributor Author

rven commented Sep 25, 2025

It seems to be important to return False iso set() :-)

@rven rven marked this pull request as ready for review September 25, 2025 13:04
@rven rven requested a review from legalsylvain September 25, 2025 13:04
@rven
Copy link
Contributor Author

rven commented Sep 26, 2025

When adding the configuration to the odoo's config file, this warning is shown

2025-09-25 14:44:14,513 556 WARNING ? odoo.tools.config: unknown option 'modules_auto_install_disabled' in the config file at /root/.odoorc, option stored as-is, without parsing

Anybody who knows how we could fix this?

@legalsylvain
Copy link
Contributor

It looks like the spirit of Odoo V19, is to have a fixed quantity of option in the [options] section, defined in the core code.

Could you try to replace :

[options]
server_wide_modules = web,module_change_auto_install

modules_auto_install_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_auto_install_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

by

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

@rven
Copy link
Contributor Author

rven commented Sep 29, 2025

It looks like the spirit of Odoo V19, is to have a fixed quantity of option in the [options] section, defined in the core code.

Could you try to replace :

[options]
server_wide_modules = web,module_change_auto_install

modules_auto_install_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_auto_install_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

by

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

I tried several ways, but the warning pops up too soon.
Odoo refatcored it completly to show a warning on non standard options.

@legalsylvain
Copy link
Contributor

I tried several ways, but the warning pops up too soon.

Could you update the logs ?

We can wait and take a look on this similar OCA modules that will have the same problems :

@rven
Copy link
Contributor Author

rven commented Sep 29, 2025

What do you mean with

Could you update the logs ?

@legalsylvain
Copy link
Contributor

What do you mean with

Could you update the logs ?

Could you put the new log, when you use [module_change_auto_install] in the odoo.cfg file ?

thanks !

@rven rven force-pushed the 19.0-mig-module_change_auto_install branch from 3522918 to fe2b3c5 Compare September 30, 2025 06:26
@rven rven force-pushed the 19.0-mig-module_change_auto_install branch from fe2b3c5 to 086cfb3 Compare September 30, 2025 06:31
@rven
Copy link
Contributor Author

rven commented Sep 30, 2025

@legalsylvain I've managed to use the following config as you mentioned

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

Can you have a look?

@rven rven mentioned this pull request Sep 30, 2025
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载