[18.0][FIX] base_name_search_improved: restore v16 behavior in _search_smart_search #3357
+4
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c6e505 to
a17d30b
Compare
…t_search In v18 `_search_smart_search` was delegating to `name_search`. This introduces an artificial limit (100 records) before other domain filters are applied, leading to incomplete results. This PR restores the original behavior from v16: - Build the domain directly in `_search_smart_search`. This makes smart search consistent again with standard search and avoids missing records.
a17d30b to
61bca51
Compare
|
Hi @pedrobaeza, do you happen to know who might see this? |
dreispt
reviewed
Oct 9, 2025
| return expression.OR([additional_domain, domain]) | ||
|
|
||
| return domain | ||
| domain = (domain and ["&"] + domain or domain) + word_domain |
There was a problem hiding this comment.
Would this work?
Suggested change
| domain = (domain and ["&"] + domain or domain) + word_domain | |
| domain = expression.AND(domain, word_domain) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v18
_search_smart_searchwas delegating toname_search. This introduces an artificial limit (100 records) before other domain filters are applied, leading to incomplete results.This PR restores the original behavior from v16:
_search_smart_search.This makes smart search consistent again with standard search and avoids missing records.