[14.0][IMP] Backport of 16.0 Improvements & Adjusted Tests #3354
Conversation
Before this change, the inverse relation from the exception to the records linked to the exception was read to determine if the rule should be added or removed from the rule detected for the current records. On large database with non blocking exceptions this lead to a performance issues since this issues a read of all the SO where the exception has been applied. With this change, we only read the information from the current records
Keeps rule information into cache to avoid to always call the ORM for static informations. This is change allows a boost into the evaluation of exception rules by avoiding useless SQL queries to retrieve rules definitions
Don't call the ORM to filter current recordset. Replace call to the orm by a call to the filtered_domain method.
|
Hi @sebastienbeau, @hparfr, |
9951c76 to
c2a80c0
Compare
|
FYI @rousseldenis, because you reviewed PR #2670 that introduced the improvements |
c2a80c0 to
531597b
Compare
|
Thx. Please also separate this PR into 2. One for the Backport one for your Feature request. |
|
@mt-software-de, I will create another PR when this here was clarified |
|
This PR has the |
531597b to
b084d3d
Compare
|
Sorry, I changed something again. I moved the new field into the other model. Makes more sense and now the unit tests of |
b084d3d to
3c7ff97
Compare
|
@lmignon and @hparfr, I removed the commit with the new field for now. I want to improve the module to have a better way to handle sub-exceptions. But this here can be merged. I will try to not change something again here :D |
|
/ocabot merge major |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at b981245. Thanks a lot for contributing to OCA. ❤️ |
Hello.
I split up my other PR #3346 to add the new field here.
And I backported a few of your commits that improve the module, @lmignon.
EDIT: Now it is mostly just a backport. My other commits improve the tests a bit.
@mt-software-de