-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[19.0] [MIG] web_calendar_slot_duration #3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
- Copy module from calendar repo 19.0-migrate-calendar - functional
Ready for review and merge. This migrates web_calendar_slot_duration to 19.0 from the working feature branch. Pre-commit is green; no unrelated changes. The addon installs cleanly; there are no tests in this module. Please prioritize this one as calendar/resource_booking depends on it. Command:
cc @OCA/web-maintainers @yajo |
I'm trying in OCA/calendar#182, and it doesn't seem to work: /ocabot migration web_calendar_slot_duration |
Thanks, @pedrobaeza. I’ll investigate and push a fix. Would you like me to also fortify this part with a few tests as part of the migration, or should I just focus on getting the codebase fully working first in the migration PR and leave tests for a follow-up PR? |
Well, HOOT/Qunit tests would be advisable for not having to check in a specific example, but I don't want you to overcharge with that. |
It’s likely that the add-ons you are loading are from wrong source paths. I will provide you with the full setup script I'm using for testing so you can continue. Thanks! |
If you’d like to reproduce it on a clean setup, here’s exactly what I’m using:
Then open Resource Bookings → Types, set a “Slot Duration” (e.g., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK then. The problem seems to be in the opened view from "Schedule" button, which may not be passing the proper options:
Anyway, you should preserve the commit history following the technical steps in the migration guide:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0
@pedrobaeza Thanks for the maintainer-tools link. I realized I developed on a single branch and later split modules by copying folders into separate branches, which broke commit history. Going forward I’ll migrate each module on its own dedicated branch using git worktrees, and I’ll preserve history by replaying the module’s 18.0 commits onto 19.0 with format-patch | git am, then applying focused migration commits. Regarding the “Schedule” button: the action opened from action_schedule isn’t passing the ideal options. It currently feeds calendar_slot_duration from the booking’s duration and misses default_duration, so the calendar snap/end time don’t match expectations. I plan to:
I’m implementing this now and will push the changes to the migration branch later today. |
Great, let me know when ready to review. |
@pedrobaeza The fixes are now in PR: OCA/calendar#182 Summary:
Applied and aligned across the migration/resource_booking branches. Manual test results:
Happy to adjust anything you’d like. Ready for review. |
Scope
Summary
Pre-commit
Tests
Command:
./odoo/odoo-bin -c odoo.conf -d odoo_calendar_tests_web_slot_001 -i web_calendar_slot_duration --test-enable --test-tags "/web_calendar_slot_duration" --log-level=info --stop-after-init
Result: module installs cleanly (no tests in addon).