[17.0][FIX] web_environment_ribbon: fix configuration image in description #3299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Oct 3, 2025
| { | ||
| "name": "Web Environment Ribbon", | ||
| "version": "17.0.1.0.2", | ||
| "version": "17.0.1.0.3", |
There was a problem hiding this comment.
Please don't change module version manually.
There was a problem hiding this comment.
Well, if it happens automatic, which place would it increase? I fear that the automatic one would increase it to 17.0.1.1.0 while this is only a fix without functional changes so it feels like the last place needs to be incremented. Do you know were i can lookup the automatic OCA version increment code?
There was a problem hiding this comment.
It depends on how we (PSCs/core maintainers/maintainers) launch the command. We have ocabot merge patch/minor/major.
There was a problem hiding this comment.
Thanks for the explanation, i removed the change of the version number from my commit.
a5cff3a to
e36e83c
Compare
pedrobaeza
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing for 19.0 #3297 i discovered that:
The description inside Odoo's Module Info featured a broken image:
With this change it is fixed:
If this is ok, i will forward port to 18.0 and 19.0 (17.0 seems to be the first version with the broken description)
Info @wt-io-it