+
Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Conversation

fraxken
Copy link
Member

@fraxken fraxken commented Mar 27, 2022

This PR implement a first draft of configuration for the NodeSecure report project.

I made some modifications to allow a better integration of the future configuration:

  • Split types and interfaces in ./src/projects
  • Split JSON Schema defs (it now work with a loader helpers).

Copy link
Member

@Kawacrepe Kawacrepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I just added a question in comments and maybe we should update the "Generation" part in README, adding the "report" configuration mode ?

Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the assertion I mentioned. 👏

@fraxken fraxken force-pushed the report-configuration branch from 2056ad2 to 7fe1c11 Compare April 2, 2022 11:44
Copy link
Member

@antoine-coulon antoine-coulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@Kawacrepe Kawacrepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

refactor(jsonSchema): split definitions in multiple .json file and add helpers to load the configuration

feat: add ReportConfiguration JSON Schema & defs

chore: review

test: enhance rc.spec.ts titles

test: enhance test title
@fraxken fraxken force-pushed the report-configuration branch from d778c87 to 1abc876 Compare April 5, 2022 07:43
@fraxken fraxken merged commit dc72d3d into main Apr 5, 2022
@fraxken fraxken deleted the report-configuration branch April 5, 2022 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载