giflib-devel Mailing List for GIFLIB

Based on docs at

    http://giflib.sourceforge.net/whatsinagif/bits_and_bytes.html
---
Hi,
Does this make sense to fix the above CVE?
Cheers,
 -- Guido

 util/giffix.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/util/giffix.c b/util/giffix.c
index 6fba84a..d1ff72b 100644
--- a/util/giffix.c
+++ b/util/giffix.c
@@ -91,9 +91,6 @@ int main(int argc, char **argv)
 	GifFileIn->SColorMap) == GIF_ERROR)
 	QuitGifError(GifFileIn, GifFileOut);
 
-    if ((LineBuffer = (GifRowType) malloc(GifFileIn->SWidth)) == NULL)
-	GIF_EXIT("Failed to allocate memory required, aborted.");
-
     /* Scan the content of the GIF file and load the image(s) in: */
     do {
 	if (DGifGetRecordType(GifFileIn, &RecordType) == GIF_ERROR)
@@ -113,6 +110,9 @@ int main(int argc, char **argv)
 		GifQprintf("\n%s: Image %d at (%d, %d) [%dx%d]:     ",
 		    PROGRAM_NAME, ++ImageNum, Col, Row, Width, Height);
 
+		if ((LineBuffer = (GifRowType) malloc(Width)) == NULL)
+		  GIF_EXIT("Failed to allocate memory required, aborted.");
+
 		/* Put the image descriptor to out file: */
 		if (EGifPutImageDesc(GifFileOut, Col, Row, Width, Height,
 		    false, GifFileIn->Image.ColorMap) == GIF_ERROR)
-- 
2.6.4