-
-
Notifications
You must be signed in to change notification settings - Fork 100
docs: update citation #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdds a new CITATION.cff metadata file for the Go WebAuthn library project and updates the LICENSE file to reflect current copyright ownership by github.com/go-webauthn/webauthn authors with 2025 date. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project's licensing and citation metadata by consolidating copyright holders and adding a formal CITATION.cff file for academic references.
- Consolidated dual copyright notices into a single 2025 copyright attribution
- Added CITATION.cff file with comprehensive metadata for citing the library
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| LICENSE | Updated copyright from dual attribution (Duo Security 2017 & go-webauthn 2021-2022) to single 2025 go-webauthn authors attribution |
| CITATION.cff | Added new citation metadata file with library details, author information, and citation guidelines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - family-names: Elliott | ||
| given-names: James | ||
| orcid: 'https://orcid.org/0009-0000-4673-5510' | ||
| date-released: '2017-10-27' |
Copilot
AI
Oct 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release date '2017-10-27' is inconsistent with the copyright year '2025' in the LICENSE file. If this represents the original project inception, consider adding a comment or adjusting to reflect the actual initial release date of this fork/version.
| date-released: '2017-10-27' | |
| # Original project inception: 2017-10-27 | |
| date-released: '2025-09-01' |
| - golang | ||
| repository-code: 'https://github.com/go-webauthn/webauthn/' | ||
| type: software | ||
| message: 'Available at https://github.com/go-webauthn/webauthn. v0.14.0 Accessed Sept, 2025.' |
Copilot
AI
Oct 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviated month 'Sept' should be 'Sep' following standard citation format conventions.
| message: 'Available at https://github.com/go-webauthn/webauthn. v0.14.0 Accessed Sept, 2025.' | |
| message: 'Available at https://github.com/go-webauthn/webauthn. v0.14.0 Accessed Sep, 2025.' |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 44.97% 44.95% -0.02%
==========================================
Files 37 37
Lines 3331 2449 -882
==========================================
- Hits 1498 1101 -397
+ Misses 1628 1143 -485
Partials 205 205 🚀 New features to boost your workflow:
|
No description provided.